Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdEmbree] minor fixes / tweaks #3

Closed
wants to merge 237 commits into from

Conversation

pmolodo
Copy link

@pmolodo pmolodo commented Jul 31, 2024

Description of Change(s)

Changes in preparation for coming HdEmbree UsdLux changes


NOTE: This chain of PRs was made separate from the PR documenting expected behavior:


  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

erikaharrison-adsk and others added 27 commits November 9, 2023 18:35
…ikely

to be accessible from the remote machine.

# Conflicts:
#	pxr/base/tf/fileUtils.cpp
these Tf file utilities in the case of reparse points on network volumes.
- Added additional text file format parser based on PEGTL
- Added tests specific to PEGTL parser
- Removed lex / yacc based parser

Contributions from Matt Kuruc and Tyler Hubbard from NVIDIA
…in the render user guide

This asset was moved from "test_assets" to "docs" in commit usd-wg/assets@75bba2e
- Update render pass multisample state based on
parameters
- Update color correction task multisample state
based on the sample count
- added template code for usdz validation
- referenced existing code in usdUtils to do the work of checking if all files are encapsulated

NOTE: this branch fails to link currently
pixar-oss and others added 23 commits September 17, 2024 15:27
…pegtl_grammar

Simplify grammar when parsing large strings

(Internal change: 2341131)
…nge 2341131

   - Move AtAtAt next to At rule

See PixarAnimationStudios#3293

(Internal change: 2341132)
This macro is used to guard compiler-specific workarounds for
non-conforming behavior. These workarounds are all for compilers
or versions of compilers that OpenUSD does not support.

(Internal change: 2341134)
…rser_copies

Reduce copies of string values during text parsing

(Internal change: 2341140)
…dsiExtComputationDependencySceneIndex.

(Internal change: 2341154)
… of USD. Also allowing for naming the render delegate something other than "Prman". In the external release we use other names like "RenderMan RIS" and "RenderMan XPU".

(Internal change: 2341190)
…dentifiers as a

   backup.

(Internal change: 2341193)
…_bindings_for_validator_registry

Add python bindings for `UsdValidator`, `UsdValidatorSuite` and `UsdValidationRegistry`

(Internal change: 2341201)
(Internal change: 2341217)
mpl::lambda's placeholders were used in def_helper.hpp to create
"inline" definitions of predicates in class definitions. We can
just define simple structs for these predicates instead.

This lets us avoid the need for mpl::apply in def_helper.hpp.
We can remove the remaining use in detail/caller.hpp by invoking
the apply metafunction directly.

BOOST_MPL_AUX_LAMBDA_SUPPORT is unnecessary for OpenUSD since
per docs it expands to nothing on conforming compilers.

(Internal change: 2341210)
Add logic metafunctions and other utilities from boost::mpl (e.g.
mpl::if_, mpl::and_, etc.) to python/detail/mpl2, reimplement
them using C++17 standard library features, and update clients.

Clients could have been updated to use the C++17 equivalents
directly, but the mpl2 indirection made the updates easier and
less error-prone, while also providing a home for functionality
that did not have a direct C++17 analogue.

Why mpl2 and not mpl? If we introduced a python::detail::mpl
namespace, code in the library that uses other parts of boost::mpl
and refers to "mpl:..." would find that namespace instead of
the intended boost::mpl namespace, which would cause symbol
lookup errors and build failures.

(Internal change: 2341215)
This change adds normals generation to the varous mesh generation utility
classes.  Similar to the point generation, the classes provide a method that
return the number of normals and a method for generating the normals into
a provided container iterator.  In addition, the interpolation mode of the
normals can also be requested.

(Internal change: 2341219)
(Internal change: 2341220)
(Internal change: 2341240)
* Expose hash functor for HdDataSourceLocator so it can used in a map

Changes in hdsi:
* Fix HdsiMaterialOverrideResolvingSceneIndex to create parameter ds for applying
a material override if the parameter ds didn't exist yet. Previously, this would return early
and no override would get applied.

(Internal change: 2341239)
These include:
- BOOST_FOREACH
- boost::binary_search
- boost::bind, boost::protect, and boost::placeholders
- boost::function
- boost::hash, boost::hash_combine
- boost::integer_traits
- boost::scoped_ptr, boost::scoped_array
- boost::tuple

These have all been replaced with C++17 standard library equivalents.

(Internal change: 2341242)
These calling conventions (e.g. __fastcall) are non-standard,
Windows specific extensions for x86 platforms and are
irrelevant for OpenUSD.

(Internal change: 2341251)
…ifiers

These clients used BOOST_PP_ENUM and BOOST_PP_ITERATE to create
template specializations for functions with different numbers of
arguments and different CV qualifiers. We now use variadic templates
to deal with the former, and a new PXR_BOOST_PYTHON_APPLY_QUALIFIERS
macro for the latter. This new macro takes some other macro and
calls it with each of the necessary CV qualifiers.

(Internal change: 2341259)
…e trig functions and instead calculate directly.

(Internal change: 2341280)
…/adsk/bugfix/mtlx_tracing

Autodesk: Expand function tracing for materialx performance profiling

(Internal change: 2341289)
…t-storm-include-functional

hdSt: add include for std.function in glslProgram.

(Internal change: 2341290)
…/adsk/bugfix/mtlx_metal_shadow

Autodesk: Bugfix for MaterialX shadows in Metal

(Internal change: 2341291)
…e-random-fix-standalone

[hdEmbree] fix for random number generation (standalone)

(Internal change: 2341332)
…e-random-seed

[hdEmbree] add HDEMBREE_RANDOM_NUMBER_SEED (hdEmbree-UsdLux-PR01)

(Internal change: 2341333)
- forward-declare some types as struct instead of class (avoids msvc
  compiler warning)
- comment typo fix
@pmolodo pmolodo force-pushed the pr/hdEmbree-usd-lux-prep branch 2 times, most recently from dabdeb5 to 5d519c7 Compare September 23, 2024 18:23
@pmolodo pmolodo closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.