Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #183 and bug #185 #207

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Fix bug #183 and bug #185 #207

merged 1 commit into from
Aug 15, 2024

Conversation

nicoleeeluo
Copy link
Contributor

Description

  1. Commit to fix bug Update single_gpu_tutorial.ipynb to use a recent snapshot #185.
  2. Commit to fix bug single_gpu_tutorial.ipynb fails to run on GPU #183.
  3. Comment out optional result verification cells to avoid similar issues
  4. Update notebook for latest NeMo Curator version

Usage

Add snippet demonstrating usage

## Checklist
<!--
Note: All commits need to be signed and signed off. This can be done via `-sS` flags while commiting
`git commit -sS -m "...."
-->
- [ ] I am familiar with the [Contributing Guide](https://github.com/NVIDIA/NeMo-Curator/blob/main/CONTRIBUTING.md).
- [ ] New or Existing tests cover these changes.
- [ ] The documentation is up to date with these changes.

Signed-off-by: Nicole Luo <[email protected]>
@ryantwolf ryantwolf self-requested a review August 15, 2024 16:52
@ryantwolf ryantwolf merged commit 22684d9 into NVIDIA:main Aug 15, 2024
3 checks passed
yyu22 pushed a commit to yyu22/NeMo-Curator that referenced this pull request Oct 9, 2024
Signed-off-by: Nicole Luo <[email protected]>
Signed-off-by: Yang Yu <[email protected]>
yyu22 pushed a commit to yyu22/NeMo-Curator that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants