Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DASK_DATAFRAME__QUERY_PLANNING environment variable #270

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

sarahyurick
Copy link
Collaborator

Since #139 is merged, we don't need to be explicitly setting DASK_DATAFRAME__QUERY_PLANNING=False anymore.

Signed-off-by: Sarah Yurick <[email protected]>
@sarahyurick sarahyurick requested a review from ryantwolf October 8, 2024 18:28
Copy link
Collaborator

@ryantwolf ryantwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You caught all the ones I could find too. Thanks!

@sarahyurick sarahyurick merged commit bf2f8f2 into NVIDIA:main Oct 9, 2024
3 checks passed
@sarahyurick sarahyurick deleted the dask_query_planning branch October 25, 2024 20:44
vinay-raman pushed a commit to vinay-raman/NeMo-Curator that referenced this pull request Nov 12, 2024
)

* remove DASK_DATAFRAME__QUERY_PLANNING False

Signed-off-by: Sarah Yurick <[email protected]>

* isort

Signed-off-by: Sarah Yurick <[email protected]>

---------

Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Vinay Raman <[email protected]>
vinay-raman pushed a commit to vinay-raman/NeMo-Curator that referenced this pull request Nov 13, 2024
)

* remove DASK_DATAFRAME__QUERY_PLANNING False

Signed-off-by: Sarah Yurick <[email protected]>

* isort

Signed-off-by: Sarah Yurick <[email protected]>

---------

Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Vinay Raman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants