Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update release.yml #452

Closed
wants to merge 1 commit into from
Closed

ci: Update release.yml #452

wants to merge 1 commit into from

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Dec 21, 2024

Description

Usage

# Add snippet demonstrating usage

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g requested a review from sarahyurick December 21, 2024 19:30
@@ -43,6 +47,7 @@ jobs:
container-workdir: /opt/NeMo-Curator
library-name: NeMo Curator
dry-run: ${{ inputs.dry-run }}
version-bump-branch: ${{ inputs.version-bump-branch }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please elaborate on how this works? My guess is that this is for handling automatic updates to the version by creating a new branch(?), but looking into https://github.com/NVIDIA/NeMo-FW-CI-templates/tree/main it's not very clear to me how this works.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry for the late response! This is mostly for pre-releases: A pre-release runs most of the time on a commit older than top of tree (due to lag of internal CI). Therefore, the input release-ref will be a commit and not a branch.

Part of doing a pre-release is attempting a version bump via PR. If release-ref is a commit, the automation lacks the information of the target branch to apply the version bump. In most cases this is main, but for more flexibility we made this an input

@ko3n1g
Copy link
Collaborator Author

ko3n1g commented Jan 3, 2025

Outdated

@ko3n1g ko3n1g closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants