Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image curation on latest RAPIDS #458

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

VibhuJawa
Copy link
Collaborator

This PR fixes image curation on latest RAPIDS to ensure compatibilty

Also fixes: #453

@VibhuJawa VibhuJawa requested a review from ryantwolf December 30, 2024 23:07
Copy link
Collaborator

@praateekmahajan praateekmahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the one comment

Copy link
Collaborator

@ryantwolf ryantwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I do want to double check though, have you verified that the partition layout is the same as before?

@VibhuJawa
Copy link
Collaborator Author

Thanks for catching this. I do want to double check though, have you verified that the partition layout is the same as before?

Yup. but i still want to file a MRE (to link the right issue etc) , moving to draft for a bit

@VibhuJawa VibhuJawa marked this pull request as draft December 31, 2024 23:20
@VibhuJawa VibhuJawa marked this pull request as ready for review January 1, 2025 22:10
@VibhuJawa
Copy link
Collaborator Author

@ryantwolf , @praateekmahajan , I think this is good to merge now. Synced internally with Rick, setting blocksize=None prevents runtime io fusion. This now works cleanly now.

Please give a final look.

@VibhuJawa VibhuJawa added the gpuci Run GPU CI/CD on PR label Jan 1, 2025
@VibhuJawa VibhuJawa merged commit 3297c1d into NVIDIA:main Jan 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpuci Run GPU CI/CD on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In cudf 25.02 use pylibcudf.transform instead of cudf._transform
3 participants