Respect file order in DocumentDataset.read_
#487
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By removing the
sorted(..)
inread_data_files_per_partition
we can be sure that the input order provided by user is respected. And in case a directory is provided as an input then we are ls-ing and then sorting before reading.Solves #486
Current Code Flow
Current flow is
DocumentDataset.read_json/parquet
calls_read_json_or_parquet
_read_json_or_parquet
which callsread_data
_read_json_or_parquet
acceptsinput_files
that could belist[files]
,list[dir]
orfile
ordir
dir
orlist[dir]
it callsget_all_files_paths_under
which has an implicitsort
read_data
acceptslist[files]
and callsread_data_blocksize
or read_data_files_per_partition`read_data_files_per_partition
performs a sortread_data_blocksize
doesn't perform a sortUsage
# Add snippet demonstrating usage
Checklist