Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add batched decorator #7

Closed
wants to merge 8 commits into from
Closed

Add batched decorator #7

wants to merge 8 commits into from

Conversation

ryantwolf
Copy link
Collaborator

@ryantwolf ryantwolf commented Mar 20, 2024 •
edited
Loading

Refactors batched to be in a decorator. This frees the user from having to be knowledgable about how the underlying DocumentFilter or DocumentModifier when initializing ScoreFilter or Modify respectively.

Unit tests pass. The following scripts were manually tested and work properly.

examples/classifier_filtering.py
examples/find_pii_and_deidentify.py
nemo_curator/scripts/find_pii_and_deidentify.py
tutorials/tinystories/main.py

@ryantwolf ryantwolf requested a review from ayushdg March 20, 2024 17:48
@ryantwolf ryantwolf force-pushed the rywolf/batched-refactor branch 2 times, most recently from 1444c12 to 34f2d7f Compare March 27, 2024 23:26
@ryantwolf ryantwolf closed this Mar 27, 2024
@ryantwolf ryantwolf deleted the rywolf/batched-refactor branch April 24, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushdg ayushdg Awaiting requested review from ayushdg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ryantwolf