-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future Implementations for classes - Measure, Money, and Date #258
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Namrata Gachchi <[email protected]>
tests/nemo_text_processing/hi/data_text_normalization/test_cases_date.txt
Show resolved
Hide resolved
…viously removed failing test cases. Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Namrata Gachchi <[email protected]>
That is correct, but we removed the cardinal's final graph to add only
digits, teens, ties, hundreds, and thousands, and it might make sense to do
the same for decimals instead of using the final graph without negatives
there as well
|
The decimal.final_graph contains the logic for the fractional part, which is essential and cannot be omitted. |
That is correct. Please make sure to include logic for thr fractional part
in your trimmed down version of it here
|
Signed-off-by: Namrata Gachchi <[email protected]>
I have incorporated the necessary decimal graph to eliminate the use of decimal.final_graph. |
Signed-off-by: Namrata Gachchi <[email protected]>
for more information, see https://pre-commit.ci
LGTM -- waiting to be able to run CI tests in the correct branch |
What does this PR do ?
This pull request introduces enhanced functionality for three classes: Measure, Money, and Date. These improvements are designed to increase usability and flexibility in handling various scenarios related to measurement units, currency transactions, and date manipulations.
Key Changes:
Measure Class:
Money Class:
Date Class:
Before your PR is "Ready for review"
Pre checks:
git commit -s
to sign.pytest
or (if your machine does not have GPU)pytest --cpu
from the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')
).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
pytest
and Sparrowhawk here.__init__.py
for every folder and subfolder, includingdata
folder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
to all newly added Python files?Copyright 2015 and onwards Google, Inc.
. See an example here.try import: ... except: ...
) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.