correct weight quantizer for grouped_linear/layernorm_linear and layernorm_mlp #1733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In grouped_linear/layernorm_linear and layernorm_mlp, weight._quantizer is not the same with quantizer saved in global buffer, and resulting in the problem of scale always being 1.
After fixing the issue, the mean relative error of the loss for 200 steps of fp8 and bf16 decreased from 0.15% to 0.09% in the two-layer deepseek example.
Fixes
Type of change
Changes
Please list the changes introduced in this PR:
refers to behaviour in linear.py: 1246-1250
Checklist: