Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Daniel Jünger <[email protected]>
  • Loading branch information
PointKernel and sleeepyjack authored Dec 13, 2023
1 parent 6cefca5 commit 8f48285
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ class open_addressing_ref_impl {
[[nodiscard]] __host__ __device__ constexpr iterator end() noexcept { return storage_ref_.end(); }

/**
* @brief Makes a copy of the current device ref using non-owned memory
* @brief Makes a copy of the current device reference using non-owned memory.
*
* This function is intended to be used to create shared memory copies of small static data
* structures, although global memory can be used as well.
Expand Down Expand Up @@ -313,7 +313,7 @@ class open_addressing_ref_impl {
}

/**
* @brief Initializes the container storage using the threads in the group `tile`.
* @brief Initializes the container storage.
*
* @note This function synchronizes the group `tile`.
*
Expand Down
2 changes: 2 additions & 0 deletions include/cuco/static_map_ref.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,8 @@ class static_map_ref
* This function is intended to be used to create shared memory copies of small static maps,
* although global memory can be used as well.
*
* @note This function synchronizes the group `tile`.
*
* @tparam CG The type of the cooperative thread group
*
* @param tile The ooperative thread group used to copy the data structure
Expand Down
2 changes: 2 additions & 0 deletions include/cuco/static_set_ref.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,8 @@ class static_set_ref
* This function is intended to be used to create shared memory copies of small static sets,
* although global memory can be used as well.
*
* @note This function synchronizes the group `tile`.
*
* @tparam CG The type of the cooperative thread group
*
* @param tile The ooperative thread group used to copy the data structure
Expand Down

0 comments on commit 8f48285

Please sign in to comment.