Add TODO notes regarding sentinel handling

NVIDIA · Oct 5, 2023 · c390393 · c390393
1 parent 5a99a56
commit c390393
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/include/cuco/detail/equal_wrapper.cuh b/include/cuco/detail/equal_wrapper.cuh
@@ -38,6 +38,7 @@ enum class equal_result : int32_t { UNEQUAL = 0, EMPTY = 1, EQUAL = 2 };
  */
 template <typename T, typename Equal>
 struct equal_wrapper {
+  // TODO: Clean up the sentinel handling since it's duplicated in ref and equal wrapper
   T empty_sentinel_;  ///< Sentinel value
   Equal equal_;       ///< Custom equality callable
 

diff --git a/include/cuco/detail/open_addressing/open_addressing_ref_impl.cuh b/include/cuco/detail/open_addressing/open_addressing_ref_impl.cuh
@@ -892,6 +892,7 @@ class open_addressing_ref_impl {
     }
   }
 
+  // TODO: Clean up the sentinel handling since it's duplicated in ref and equal wrapper
   value_type empty_slot_sentinel_;  ///< Sentinel value indicating an empty slot
   detail::equal_wrapper<key_type, key_equal> predicate_;  ///< Key equality binary callable
   probing_scheme_type probing_scheme_;                    ///< Probing scheme