Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] replace int_div_ceil with std::cuda::ceil #651

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

willtryagain
Copy link

Closes #631

Need assistance to add tests

Copy link

copy-pr-bot bot commented Dec 5, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@PointKernel
Copy link
Member

/ok to test

@PointKernel PointKernel added the type: improvement Improvement / enhancement to an existing function label Dec 5, 2024
@PointKernel
Copy link
Member

@willtryagain Thank you for your contribution!

The CI test failure is caused by an issue with CCCL (https://godbolt.org/z/94nYnvqMW), which may take some time to resolve. Could you please keep the PR open while we backlog it for now? We’ll handle the rest once cuda::std::ceil is made constexpr.

@PointKernel PointKernel added the P3: Backlog Unprioritized label Dec 5, 2024
@PointKernel
Copy link
Member

/ok to test

@willtryagain
Copy link
Author

Hello @PointKernel , can you pleas tell if the check is failing because of problem in my code? or is it still cuda::std::ceil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3: Backlog Unprioritized type: improvement Improvement / enhancement to an existing function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace int_div_ceil with cuda::std::ceil
2 participants