Skip to content

Import cudart symbols properly #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

leofang
Copy link
Member

@leofang leofang commented Apr 2, 2025

Currently I hand-modify this, but we should be able to autogen it.

@leofang leofang requested a review from vzhurba01 April 2, 2025 18:20
@leofang leofang self-assigned this Apr 2, 2025
Copy link
Contributor

copy-pr-bot bot commented Apr 2, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Apr 2, 2025

/ok to test

Copy link

github-actions bot commented Apr 2, 2025

@vzhurba01
Copy link
Collaborator

I can apply the fix in autogen and push a commit to this PR.

@vzhurba01
Copy link
Collaborator

I'll need #544 to be merged first for this to be a clean commit though.

@vzhurba01 vzhurba01 self-assigned this Apr 4, 2025
@leofang leofang removed their assignment Apr 5, 2025
@leofang leofang added this to the cuda-python 12.9.0 & 11.8.7 milestone Apr 5, 2025
@leofang leofang added enhancement Any code-related improvements P1 Medium priority - Should do cuda.bindings Everything related to the cuda.bindings module P2 Low priority - Nice to have and removed P1 Medium priority - Should do labels Apr 5, 2025
@leofang
Copy link
Member Author

leofang commented May 4, 2025

This is done as part of #597. Thanks, @vzhurba01!

@leofang leofang closed this May 4, 2025
@leofang leofang deleted the fix_pxi branch May 4, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P2 Low priority - Nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants