feat: Introduce shell metacharacter escaping for exec #491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to mitigate potential security vulnerabilities arising from shell injection attacks, this PR introduces a function to escape shell metacharacters which may be present in command-line arguments.
It's worth noting that two potential vulnerabilities still exist in
nvidia-container-toolkit/tools/container/nvidia-toolkit/run.go
Lines 249 to 252 in 973a663
nvidia-container-toolkit/tools/container/nvidia-toolkit/run.go
Lines 275 to 278 in 973a663
o.runtimeArgs
is directly interpolated intocmdline
, leaving it susceptible to injection attacks. To address this, a more comprehensive solution would involve reimplementingo.runtimeArgs
as[]string
, allowing for proper sanitization using the introducedoci.Escape()
function; however, this likely involves a breaking change.