Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CI does not catch missing copyright or license on new files #2571

Closed
jlowe opened this issue Nov 5, 2024 · 2 comments · Fixed by #2605
Closed

[BUG] CI does not catch missing copyright or license on new files #2571

jlowe opened this issue Nov 5, 2024 · 2 comments · Fixed by #2605
Assignees
Labels
bug Something isn't working build

Comments

@jlowe
Copy link
Contributor

jlowe commented Nov 5, 2024

One of the CI runs on #2559 should have failed due to a missing copyright and license header on a source file but it did not. We should use something like apache-rat-plugin to catch this error of omission in CI.

@jlowe jlowe added ? - Needs Triage bug Something isn't working build labels Nov 5, 2024
@mattahrens
Copy link
Collaborator

@pxLi can this be addressed with the common build repo?

@pxLi
Copy link
Collaborator

pxLi commented Nov 6, 2024

@pxLi can this be addressed with the common build repo?

Yes, this could be a good shared action usage to verify the license header change.

I will create another ticket in common repo.

cc @YanxuanLiu NVIDIA/spark-rapids-common#9 please help consider scenarios for multiple projects, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants