Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright header check [skip ci] #2605

Merged
merged 11 commits into from
Nov 20, 2024

Conversation

YanxuanLiu
Copy link
Collaborator

@YanxuanLiu YanxuanLiu commented Nov 19, 2024

fix #2571

Add github workflow license-header-check to check copyright/license header for files in Pull Request.

A common action https://github.com/NVIDIA/spark-rapids-common/blob/main/license-header-check/action.yml is used for the check. The action requires an argument included_file_patterns for the scale of files to check. Users can also input argument excluded_file_patterns to exclude files based on included files.

If files without copyright header Copyright (c) .*, NVIDIA CORPORATION. or with expired date exists, the workflow would return failed.

Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
@pxLi
Copy link
Collaborator

pxLi commented Nov 19, 2024

the change looks good,
but the failed action itself did not provide any useful info for debug https://github.com/NVIDIA/spark-rapids-jni/actions/runs/11907547850/job/33181412159?pr=2605

@YanxuanLiu
Copy link
Collaborator Author

the change looks good, but the failed action itself did not provide any useful info for debug https://github.com/NVIDIA/spark-rapids-jni/actions/runs/11907547850/job/33181412159?pr=2605

I'll test in another PR and add some print info for debug to the common action.

@pxLi
Copy link
Collaborator

pxLi commented Nov 19, 2024

the change looks good, but the failed action itself did not provide any useful info for debug https://github.com/NVIDIA/spark-rapids-jni/actions/runs/11907547850/job/33181412159?pr=2605

I'll test in another PR and add some print info for debug to the common action.

sure, try test first against your JNI fork with branch-24.12 thanks

Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu YanxuanLiu changed the title Copyright header check Copyright header check [skip ci] Nov 19, 2024
@YanxuanLiu
Copy link
Collaborator Author

build

@pxLi pxLi requested review from jlowe and gerashegalov November 19, 2024 08:48
@pxLi pxLi added the build label Nov 19, 2024
@pxLi pxLi marked this pull request as ready for review November 20, 2024 00:25
@pxLi
Copy link
Collaborator

pxLi commented Nov 20, 2024

seems the change did not cover scenarios like,
https://github.com/NVIDIA/spark-rapids-jni/blob/branch-24.12/src/main/fbs/profiler.fbs *.fbs
https://github.com/NVIDIA/spark-rapids-jni/blob/branch-24.12/ci/settings.xml *.xml
and folder for binaries like build/*

Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu
Copy link
Collaborator Author

seems the change did not cover scenarios like, https://github.com/NVIDIA/spark-rapids-jni/blob/branch-24.12/src/main/fbs/profiler.fbs *.fbs https://github.com/NVIDIA/spark-rapids-jni/blob/branch-24.12/ci/settings.xml *.xml and folder for binaries like build/*

Thanks! Added these patterns.

Copy link
Collaborator

@pxLi pxLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please keep monitoring the PR check status of this repo. we can enable it as a required check when it performs stably

@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu YanxuanLiu merged commit e9a73f1 into NVIDIA:branch-24.12 Nov 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CI does not catch missing copyright or license on new files
2 participants