-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copyright header check [skip ci] #2605
Copyright header check [skip ci] #2605
Conversation
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
the change looks good, |
I'll test in another PR and add some print info for debug to the common action. |
sure, try test first against your JNI fork with branch-24.12 thanks |
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
build |
seems the change did not cover scenarios like, |
Signed-off-by: YanxuanLiu <[email protected]>
Thanks! Added these patterns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please keep monitoring the PR check status of this repo. we can enable it as a required check when it performs stably
build |
fix #2571
Add github workflow
license-header-check
to check copyright/license header for files in Pull Request.A common action https://github.com/NVIDIA/spark-rapids-common/blob/main/license-header-check/action.yml is used for the check. The action requires an argument
included_file_patterns
for the scale of files to check. Users can also input argumentexcluded_file_patterns
to exclude files based on included files.If files without copyright header
Copyright (c) .*, NVIDIA CORPORATION.
or with expired date exists, the workflow would return failed.