Improve quoting of command line arguments for build/run scripts #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <[email protected]>
|
build |
gerashegalov
approved these changes
Oct 19, 2023
| @@ -50,7 +50,7 @@ if (( $# == 0 )); then | |||
| DOCKER_OPTS="${DOCKER_OPTS} -it" | |||
| RUN_CMD="/bin/bash" | |||
| else | |||
| RUN_CMD="$*" | |||
| RUN_CMD="${@@Q}" | |||
There was a problem hiding this comment.
nit: we would not need to build a string from an array if we used the alternative syntax https://access.redhat.com/documentation/en-us/red_hat_software_collections/3/html/packaging_guide/sect-enabling_the_software_collection
with -- on L77
if (( $# == 0 )); then
# no arguments gets an interactive shell
DOCKER_OPTS="${DOCKER_OPTS} -it"
- RUN_CMD="/bin/bash"
+ RUN_CMD=("/bin/bash")
else
- RUN_CMD="${@@Q}"
+ RUN_CMD=("$@")
fi
...
- scl enable devtoolset-11 "$RUN_CMD"
+ scl enable devtoolset-11 -- "${RUN_CMD[@]}"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1092. This adds proper handling of arguments, quoting them when necessary to preserve them through double-parsing by the shell. Tested this by running a standard build-in-docker command along with one that specifies multiple GPU architectures that failed in the past, e.g.:
build-in-docker -DGPU_ARCHS="75-real;80-real;86-real;90-real" clean install