Adding IP6 characters into valid character list for URI parsing #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Wilson <[email protected]>
hyperbolic2346
force-pushed
the
mwilson/ip6-parsing
branch
from
69439e9 to
72a5f39
Compare
|
build |
Signed-off-by: Mike Wilson <[email protected]>
Signed-off-by: Mike Wilson <[email protected]>
|
build |
1 similar comment
|
build |
|
build |
|
Much more IPv6 validation needs to happen here, working on that in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was noted in review of the plugin changes to add support for
parse_urlthat IP6 wasn't properly validating. This change fixes that to bring the kernel in line with Spark on IP6 addresses.