Pin scikit-learn dependency for shap #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lee Yang <[email protected]>
leewyang
added
the
user_tools
amahussein
reviewed
Jan 9, 2025
There was a problem hiding this comment.
I checked that sickit-learn should be fine with python 3.9+
Is there any concern with the other dependencies I see on the package pypi page? matplotlib is the library I see in the error of the DLI docker.
Scikit-learn plotting capabilities (i.e., functions start with plot_ and classes end with Display) require Matplotlib (>= 3.3.4). For running the examples Matplotlib >= 3.3.4 is required. A few examples require scikit-image >= 0.17.2, a few examples require pandas >= 1.1.5, some examples require seaborn >= 0.9.0 and plotly >= 5.14.0.
| @@ -81,6 +81,7 @@ dependencies = [ | |||
| "xgboost==2.1.3", | |||
| # used for model interpretability. python [3.9, 3.12] | |||
| "shap==0.46.0", | |||
| "scikit-learn==1.5.2", | |||
There was a problem hiding this comment.
Can we add a comment that sickit-learn is required as dependency of shap?
Signed-off-by: Lee Yang <[email protected]>
amahussein
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins the
scikit-learndependency ofshapto version 1.5.2, since the most recent 1.6.0 version (released on 12/9/2024) modified the behavior of theBaseEstimator.__sklearn_tags__, which is causing this error when runningoptunahyperparameter search: