Update tests to not have hard coded fallback when not needed #10042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
NVnavkumar
reviewed
Dec 13, 2023
| from data_gen import * | ||
| from datetime import date, datetime, timezone | ||
| from marks import ignore_order, incompat, allow_non_gpu | ||
| from pyspark.sql.types import * | ||
| from spark_session import with_cpu_session, is_before_spark_330, is_before_spark_350 | ||
| import pyspark.sql.functions as f | ||
|
|
||
| # Some operations only work in UTC specifically | ||
| non_utc_ts_allow = ['ProjectExec'] if not is_utc() else [] |
There was a problem hiding this comment.
Suggested change
| non_utc_ts_allow = ['ProjectExec'] if not is_utc() else [] | |
| non_utc_tz_allow = ['ProjectExec'] if not is_utc() else [] |
| # Some operations only work in UTC specifically | ||
| non_utc_ts_allow = ['ProjectExec'] if not is_utc() else [] | ||
| # Others work in all supported time zones | ||
| non_supported_ts_allow = ['ProjectExec'] if not is_supported_time_zone() else [] |
There was a problem hiding this comment.
Suggested change
| non_supported_ts_allow = ['ProjectExec'] if not is_supported_time_zone() else [] | |
| non_supported_tz_allow = ['ProjectExec'] if not is_supported_time_zone() else [] |
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the comments I made in #9816 (review) after the merge happened. Feedback is appreciated. I ran it manually with a number of time zones to verify that it works as expected.