Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version to v23.12.1 [skip ci] #10123

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Change version to v23.12.1 [skip ci] #10123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/dev/shims.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,17 +68,17 @@ Using JarURLConnection URLs we create a Parallel World of the current version wi
Spark 3.0.2's URLs:

```text
jar:file:/home/spark/rapids-4-spark_2.12-23.12.0.jar!/
jar:file:/home/spark/rapids-4-spark_2.12-23.12.0.jar!/spark3xx-common/
jar:file:/home/spark/rapids-4-spark_2.12-23.12.0.jar!/spark302/
jar:file:/home/spark/rapids-4-spark_2.12-23.12.1.jar!/
jar:file:/home/spark/rapids-4-spark_2.12-23.12.1.jar!/spark3xx-common/
jar:file:/home/spark/rapids-4-spark_2.12-23.12.1.jar!/spark302/
```

Spark 3.2.0's URLs :

```text
jar:file:/home/spark/rapids-4-spark_2.12-23.12.0.jar!/
jar:file:/home/spark/rapids-4-spark_2.12-23.12.0.jar!/spark3xx-common/
jar:file:/home/spark/rapids-4-spark_2.12-23.12.0.jar!/spark320/
jar:file:/home/spark/rapids-4-spark_2.12-23.12.1.jar!/
jar:file:/home/spark/rapids-4-spark_2.12-23.12.1.jar!/spark3xx-common/
jar:file:/home/spark/rapids-4-spark_2.12-23.12.1.jar!/spark320/
```

### Late Inheritance in Public Classes
Expand Down
10 changes: 5 additions & 5 deletions sql-plugin-api/src/main/scala/com/nvidia/spark/rapids/ShimLoader.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ import org.apache.spark.util.MutableURLClassLoader
Each shim can see a consistent parallel world without conflicts by referencing
only one conflicting directory.
E.g., Spark 3.2.0 Shim will use
jar:file:/home/spark/rapids-4-spark_2.12-23.12.0.jar!/spark3xx-common/
jar:file:/home/spark/rapids-4-spark_2.12-23.12.0.jar!/spark320/
jar:file:/home/spark/rapids-4-spark_2.12-23.12.1.jar!/spark3xx-common/
jar:file:/home/spark/rapids-4-spark_2.12-23.12.1.jar!/spark320/
Spark 3.1.1 will use
jar:file:/home/spark/rapids-4-spark_2.12-23.12.0.jar!/spark3xx-common/
jar:file:/home/spark/rapids-4-spark_2.12-23.12.0.jar!/spark311/
jar:file:/home/spark/rapids-4-spark_2.12-23.12.1.jar!/spark3xx-common/
jar:file:/home/spark/rapids-4-spark_2.12-23.12.1.jar!/spark311/
Using these Jar URL's allows referencing different bytecode produced from identical sources
by incompatible Scala / Spark dependencies.
*/
Expand Down Expand Up @@ -367,4 +367,4 @@ object ShimLoader extends Logging {
def loadGpuColumnVector(): Class[_] = {
ShimReflectionUtils.loadClass("com.nvidia.spark.rapids.GpuColumnVector")
}
}
}