Fix the canonicalizing for GPU file scan #10137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original output should be used when creating a canonicalized GPU file scan, because the rule `prunePartitionForFileSourceScan` in Plugin may remove the partition columns that are not used by the first downstream ProjectExec for some patterns, leading to some partition columns not exist in the finalized output. Then the `AttributeReference`s in some filters but not in the output will not be canonicalized. --------- Signed-off-by: Firestarman <[email protected]>
Signed-off-by: Firestarman <[email protected]>
firestarman
changed the title
|
build |
revans2
reviewed
Jan 2, 2024
jlowe
approved these changes
Jan 2, 2024
|
Thx all. |
firestarman
added a commit
to firestarman/spark-rapids
that referenced
this pull request
Jan 18, 2024
This reverts commit ace4870.
nvliyuan
pushed a commit
to firestarman/spark-rapids
that referenced
this pull request
Jan 18, 2024
This reverts commit ace4870.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #10136
The original output should be used when creating a canonicalized GPU file scan.
Because the rule
prunePartitionForFileSourceScanwill remove partition columns that are notused by the first downstream
ProjectExecfor some patterns, leading to some partition columnsnot exist in the finalized output. Then the
AttributeReferences in thepartitionFiltersbut excludedfrom the finalized output will not be canonicalized.