Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Failing Build for Databricks 11.3 on branch 23.12 [databricks] #10435

Closed
wants to merge 4 commits into from

Conversation

razajafri
Copy link
Collaborator

@razajafri razajafri commented Feb 16, 2024

Revert "PythonRunner Changes [databricks]"

fixes #10432

@razajafri razajafri changed the title Fixed Build for branch 23.12 [databricks] Fixed Failing Build for Databricks 11.3 on branch 23.12 [databricks] Feb 16, 2024
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a need to support similar python runner changed in 11.3 or is that not supported any longer?

Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue for this build failure that the PR is fixing?

Comment on lines 57 to 55
if [[ ! -d $HOME/apache-maven-3.6.3 ]]; then
wget https://archive.apache.org/dist/maven/maven-3/3.6.3/binaries/apache-maven-3.6.3-bin.tar.gz -P /tmp
tar xf /tmp/apache-maven-3.6.3-bin.tar.gz -C $HOME
sudo ln -s $HOME/apache-maven-3.6.3/bin/mvn /usr/local/bin/mvn
fi
sudo apt install -y maven rsync
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not revert this part, deterministic Maven version is more robust either way regardless whether the apt package for Maven is back

@razajafri
Copy link
Collaborator Author

While triaging an issue yesterday, I wasn't able to build the plugin for 23.12 or 24.04. It only worked after reverting the change.

Is there a need to support similar python runner changed in 11.3 or is that not supported any longer?

AFAIK Databricks has reverted this for 11.3. That could change in the future

@razajafri
Copy link
Collaborator Author

build

@GaryShen2008
Copy link
Collaborator

Why this PR targets branch-23.12? Do we need to fix it in 23.12?

@razajafri
Copy link
Collaborator Author

Why this PR targets branch-23.12? Do we need to fix it in 23.12?

Yes, because databricks has rolled back the change for PythonRunner

@razajafri
Copy link
Collaborator Author

Since we don't plan on issuing another 23.12 release and given that the PythonRunner changes might be pulled back in in the near future, we are closing this issue

@razajafri razajafri closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants