Deploy the sources and Javadoc JARs in the nightly CICD [skip ci] #11915
Conversation
Deploy the sources and javadoc JARS to make sure nightly CICD includes all jars required by Sonatype release Deploy dist jars in the final step to ensure that the POM files are not overwritten Signed-off-by: Tim Liu <[email protected]>
NvTimLiu
requested review from
jlowe,
revans2,
tgravescs and
gerashegalov
as code owners
|
Skip CI, pre-merge build can not cover this change Local nightly CI job got PASS:
|
jenkins/spark-nightly-build.sh
Outdated
| @@ -189,6 +190,18 @@ if [[ $SKIP_DEPLOY != 'true' ]]; then | |||
| -Dmaven.scaladoc.skip -Dmaven.scalastyle.skip=true \ | |||
| $MVN_URM_MIRROR -Dmaven.repo.local=$M2DIR \ | |||
| -Dcuda.version=$DEFAULT_CUDA_CLASSIFIER | |||
|
|
|||
| # dist module does not have javadoc and sources jars, use 'sql-plugin' ones instead | |||
| SQL_ART_PATH="$(echo -n $SQL_PLGUIN_PATH/target/spark*)/rapids-4-spark-sql_${SCALA_BINARY_VER}-${ART_VER}" | |||
There was a problem hiding this comment.
https://github.com/NVIDIA/spark-rapids/blob/branch-25.02/jenkins/deploy.sh#L72-L77
can we share the steps in some common place?
There was a problem hiding this comment.
We can share the jenkins/deploy.sh for both nightly and sonatype deploy
Support deploying both Scala 2.12 and Scala 2.13 artifacts in jenkins/deploy.sh Signed-off-by: Tim Liu <[email protected]>
jenkins/spark-nightly-build.sh
Outdated
| mv ${TMP_PATH}/${ART_ID}-${ART_VER}-*.jar ${DIST_PATH}/target/ | ||
| fi | ||
| # Deploy dist jars in the final step to ensure that the POM files are not overwritten | ||
| jenkins/deploy.sh |
There was a problem hiding this comment.
nit: it would be nice to explicitly put some defaults ENV at the place to call the script like SERVER_URL for the new nightly deployment change. especially it would be different with the script default SERVER_URL=${SERVER_URL:-"file:/tmp/local-release-repo"}
There was a problem hiding this comment.
updated.
Set default environments to deploy artifacts to the internal maven repo
Signed-off-by: Tim Liu <[email protected]>
|
build |
|
Local nightly CI got PASS for both scala
|
For fixing: #11914
Deploy the sources and javadoc JARS to make sure nightly CICD includes all jars required by Sonatype release
Deploy dist jars in the final step to ensure that the POM files are not overwritten