Clean up MSVC warnings #1141
Merged
Clean up MSVC warnings #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C4100: Unreferenced formal parameter C4101: Unreferenced local variable C4127: Conditional expression is constant C4324: Structure was padded due to alignas specifier C4456: Declaration hides previous local declaration C4459: Declaration hides global declaration
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppressed the following warnings via command line options:
Fixed two instances of "C4244: Type conversion leads to possible loss of data" in
static_thread_pool.hppby improving integer type safety.Multiple instances of "C4702: Unreachable code" still remain. It's not a warning that should be suppressed, but I also did not want to go through all those cases in this PR.
This PR depends on #1137.