Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3481 R2 - Incorporate changes from the "bulk issues" paper #1500

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

lucteo
Copy link
Contributor

@lucteo lucteo commented Mar 24, 2025

See http://wg21.link/P3481R2

Main changes:

  • add bulk_chunked and bulk_unchunked
  • bulk takes an additional execution policy
  • bulk is specified in terms of bulk_chunked

Copy link

copy-pr-bot bot commented Mar 24, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@lucteo
Copy link
Contributor Author

lucteo commented Mar 24, 2025

@ericniebler : this is not yet ready, but I wanted to push it up, so that you have a chance to see it earlier.

I'm planning to change the schedulers (static_thread_pool, libdispatch, parallel_scheduler) to be customized in terms of bulk_unchunked.

I'm also expecting some issues on the CUDA sides; I'm not sure how can I move forward on that side. Any help is greatly appreciated.

@ericniebler
Copy link
Collaborator

/ok to test

@lucteo
Copy link
Contributor Author

lucteo commented Mar 25, 2025

The GCC failure should be fixed. I'm not sure how to approach the Windows failure :(

@ericniebler
Copy link
Collaborator

/ok to test

@ericniebler
Copy link
Collaborator

@lucteo you can disregard the GPU CI failures. they are infra-related. the msvc failures are real though.

@lucteo
Copy link
Contributor Author

lucteo commented Mar 26, 2025

@ericniebler : there are some issues on the GPU side as well caused by my patch. I will temporarily pause this for 2 weeks, as I need to finish my ACCU presentation for next week.

@ericniebler
Copy link
Collaborator

/ok to test

@ericniebler
Copy link
Collaborator

ericniebler commented Mar 31, 2025

@lucteo i have addressed the GPU build problem. the msvc build failure remains.

@ericniebler
Copy link
Collaborator

/ok to test

@ericniebler
Copy link
Collaborator

/ok to test

@ericniebler
Copy link
Collaborator

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants