Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark daily chart #152

Merged
merged 21 commits into from
Aug 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/config.php
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ function() {
}
}


$contents = file_get_contents("/etc/birdnet/birdnet.conf");
$contents = preg_replace("/SITE_NAME=.*/", "SITE_NAME=\"$site_name\"", $contents);
$contents = preg_replace("/LATITUDE=.*/", "LATITUDE=$latitude", $contents);
Expand Down Expand Up @@ -176,6 +175,10 @@ function() {
function() {
window.parent.document.location.reload();
}, 1000);</script>";

shell_exec("sudo systemctl restart chart_viewer.service");
// the sleep allows for the service to restart and image to be generated
sleep(5);
}

$fh = fopen("/etc/birdnet/birdnet.conf", "w");
Expand Down Expand Up @@ -649,6 +652,7 @@ function runProcess() {

<table class="settingstable"><tr><td>
<h2>Color scheme </h2>
Note: when changing themes the daily chart may need a page refresh before updating.<br><br>
<label for="color_scheme">Color scheme for the site : </label>
<select name="color_scheme" class="testbtn">
<?php
Expand Down
33 changes: 27 additions & 6 deletions scripts/daily_plot.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ def get_data(now=None):

# Function to show value on bars - from https://stackoverflow.com/questions/43214978/seaborn-barplot-displaying-values
def show_values_on_bars(ax, label):
conf = get_settings()

for i, p in enumerate(ax.patches):
x = p.get_x() + p.get_width() * 0.9
y = p.get_y() + p.get_height() / 2
Expand All @@ -43,7 +45,12 @@ def show_values_on_bars(ax, label):
# Species Count Total
value = '{:n}'.format(p.get_width())
bbox = {'facecolor': 'lightgrey', 'edgecolor': 'none', 'pad': 1.0}
ax.text(x, y, value, bbox=bbox, ha='center', va='center', size=9, color='darkgreen')
if conf['COLOR_SCHEME'] == "dark":
color = 'black'
else:
color = 'darkgreen'

ax.text(x, y, value, bbox=bbox, ha='center', va='center', size=9, color=color)


def wrap_width(txt):
Expand All @@ -70,9 +77,16 @@ def create_plot(df_plt_today, now, is_top=None):

df_plt_selection_today = df_plt_today[df_plt_today.Com_Name.isin(plt_selection_today.index)]

conf = get_settings()

# Set up plot axes and titles
height = max(readings / 3, 0) + 1.06
f, axs = plt.subplots(1, 2, figsize=(10, height), gridspec_kw=dict(width_ratios=[3, 6]), facecolor='#77C487')
if conf['COLOR_SCHEME'] == "dark":
facecolor = 'darkgrey'
else:
facecolor = 'none'

f, axs = plt.subplots(1, 2, figsize=(10, height), gridspec_kw=dict(width_ratios=[3, 6]), facecolor=facecolor)

# generate y-axis order for all figures based on frequency
freq_order = df_plt_selection_today['Com_Name'].value_counts().index
Expand All @@ -86,8 +100,12 @@ def create_plot(df_plt_today, now, is_top=None):
norm = plt.Normalize(confmax.values.min(), confmax.values.max())
if is_top or is_top is None:
# Set Palette for graphics
pal = "Greens"
colors = plt.cm.Greens(norm(confmax)).tolist()
if conf['COLOR_SCHEME'] == "dark":
pal = "Greys"
colors = plt.cm.Greys(norm(confmax)).tolist()
else:
pal = "Greens"
colors = plt.cm.Greens(norm(confmax)).tolist()
if is_top:
plot_type = "Top"
else:
Expand All @@ -102,7 +120,7 @@ def create_plot(df_plt_today, now, is_top=None):

# Generate frequency plot
plot = sns.countplot(y='Com_Name', hue='Com_Name', legend=False, data=df_plt_selection_today,
palette=colors, order=freq_order, ax=axs[0])
palette=colors, order=freq_order, ax=axs[0], edgecolor='lightgrey')
Nachtzuster marked this conversation as resolved.
Show resolved Hide resolved

# Prints Max Confidence on bars
show_values_on_bars(axs[0], confmax)
Expand Down Expand Up @@ -136,7 +154,10 @@ def create_plot(df_plt_today, now, is_top=None):
# Set color and weight of tick label for current hour
for label in plot.get_xticklabels():
if int(label.get_text()) == now.hour:
label.set_color('yellow')
if conf['COLOR_SCHEME'] == "dark":
label.set_color('white')
else:
label.set_color('yellow')

plot.set_xticklabels(plot.get_xticklabels(), rotation=0, size=8)

Expand Down
1 change: 1 addition & 0 deletions scripts/update_birdnet_snippets.sh
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ fi
if [ -L /usr/local/bin/analyze.py ];then
rm -f /usr/local/bin/analyze.py
fi

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't do changes in unrelated files

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there is general code cleanup do you want that in a separate PR? In this case it's adding a blank line between two functions that didn't have the blank line and should have.

image

if [ -L /usr/local/bin/birdnet_analysis.sh ];then
rm -f /usr/local/bin/birdnet_analysis.sh
fi
Expand Down
Loading