Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional apprise notification option #88

Merged
merged 4 commits into from
Jun 9, 2024

Conversation

OliNau
Copy link

@OliNau OliNau commented Jun 4, 2024

Added $maskedlistenurl as an option for apprise notifications.

Tries to close #80

Added $maskedlistenurl as an option for apprise notifications.
@OliNau OliNau changed the title Update config.php Add additional apprise notification option Jun 4, 2024
@lloydbayley
Copy link

Tested this on my dev installation and it works for me. Nice one!

@OliNau
Copy link
Author

OliNau commented Jun 5, 2024

Mmm, additional testing shows this only seems to work when pressing the 'testing' button, but not with actual detections. So it should not be merged at the moment, I think.

Make sure $maskedlistenurl also works with default detections, and not only when testing.
@OliNau
Copy link
Author

OliNau commented Jun 5, 2024

Okay, the python parts is also updated, so it should work now.

@Nachtzuster
Copy link
Owner

Nice.
I do find the maskedlistenurl name a bit strange.
suggestions: prettyurl or friendlyurl ... ?

@OliNau
Copy link
Author

OliNau commented Jun 5, 2024

I chose the term because it's consistent with how it's referred to in Discord docs and other places that use Markdown. They call it 'masked links'.

However, the name isn't a big deal to me, so feel free to pick a name you prefer! :)

@OliNau
Copy link
Author

OliNau commented Jun 6, 2024

@Nachtzuster, What do you think about markdownurl?

@lloydbayley
Copy link

Fair point, well-made. I hadn't tested it in 'live' mode. I'm sorry about that. Perhaps I shouldn't be replying to issues.

@OliNau
Copy link
Author

OliNau commented Jun 6, 2024

@lloydbayley, oh no, I appreciate your feedback. It's just a little weird that the exact same system is implemented both in PHP and in Python, with the former only activating when you push the test button, while the latter works with actual detections.

@lloydbayley
Copy link

lloydbayley commented Jun 6, 2024

I know, I keep forgetting the lack of logic in the code. I'm very sorry, I should have checked more.

@Nachtzuster
Copy link
Owner

@OliNau I've been testing this: hiding the url does not work for eg. email and telegram.
Not sure if it is worth adding it only works with Discord

@OliNau
Copy link
Author

OliNau commented Jun 7, 2024 via email

@Nachtzuster
Copy link
Owner

@OliNau
ok, understood.
About the naming: could you switch to friendlyurl?

@Nachtzuster
Copy link
Owner

@lloydbayley an extra pair of eyes never hurts, thanks for the support.

@lloydbayley
Copy link

Well, thank you. And there I was thinking you would rather not have me here.

OliNau added 2 commits June 9, 2024 04:18
Changed maskedlistenurl to friendlyurl
Changed maskedlistenurl to friendlyurl
@OliNau
Copy link
Author

OliNau commented Jun 9, 2024

Changes made. If you have time, feel free to test it @lloydbayley :)

@Nachtzuster Nachtzuster merged commit e6f48f8 into Nachtzuster:main Jun 9, 2024
1 check failed
@OliNau OliNau deleted the patch-1 branch June 9, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User friendly $listenurl links in notifications
3 participants