This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Fix for Issue #1096 (Model binding errors for invalid dates) #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This is a possible fix for Issue #1096, which is about throwing ModelBindingException for strings that cannot be parsed as dates. That wasn't happening because the FallbackConverter was eating the FormatException thrown by the DateTimeConverter and returning null. My fix is to just rethrow the exception. That might have a broader impact for other types that use the FallbackConverter, but it didn't break any tests, with the exception of Should_ignore_properties_that_cannot_be_converted. I think Should_ignore_properties_that_cannot_be_converted is now invalid because it is asserting that an invalid DateTime should be ignored. Changing that behavior was the whole point.