Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: True Metal should not be broken! #45

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

arkel-s
Copy link
Contributor

@arkel-s arkel-s commented Dec 13, 2024

Recent update of Java 21 broke the Dockerfile. The pom.xml file is also broken.
Fixing it, True Metal should never be broken 🤘

Also adding Metal dependency as requested by #36
Cleaned the Redme as requested by #44

@arkel-s arkel-s changed the title fix: Pom and Docker for Java 21 fix: True Metal should not be broken! Dec 13, 2024
@external-torx
Copy link

I support this change and I'm doing all the same stuff to my pom.xml locally to get to run but I would prefer to keep the javac instructions in the README on the basis that no one writing/running HelloWorld for the first time should need to learn maven to do it.

@arkel-s arkel-s force-pushed the fix/java21 branch 2 times, most recently from 48f1264 to 577d901 Compare December 16, 2024 12:55
@arkel-s
Copy link
Contributor Author

arkel-s commented Dec 16, 2024

I support this change and I'm doing all the same stuff to my pom.xml locally to get to run but I would prefer to keep the javac instructions in the README on the basis that no one writing/running HelloWorld for the first time should need to learn maven to do it.

Thanks for having a look @external-torx
Actually I removed javac in the readme but kept the Single File source-code execution which works fine without Maven, as javac is not needed for this simple use case.
java src/main/java/it/nanowar/ofsteel/helloworld/HelloWorldMainLauncherClass.java

See Rendered REAMDE.md

Is it fine for you?

Recent update of Java 21 broke the Dockerfile. The pom.xml file is also
broken. Fixing it 🤘
@arkel-s arkel-s changed the title fix: True Metal should not be broken! fix: True Metal should not be broken! fixes #36 #44 Dec 16, 2024
@arkel-s arkel-s changed the title fix: True Metal should not be broken! fixes #36 #44 fix: True Metal should not be broken! Dec 16, 2024
@external-torx
Copy link

Looks great to me, but I'm just a spectator, not one of the maintainers of the repo

@NanowarOfSteel NanowarOfSteel merged commit b2f080b into NanowarOfSteel:master Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants