Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fix GitHub CI workflow #441

Merged

Conversation

SuperITMan
Copy link
Member

@SuperITMan SuperITMan commented Dec 12, 2023

Upgrade NodeJS to v14 and npm to v8.

Add --yes option to npx usage in "test.sh".

Add "@types/node": "~14.14.31" devDependency

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

CI workflow is using deprecated actions and commands.

Tests are broken because of npx waiting for a user prompt + new version of @types/node breaks compatibility with TypeScript 3.x.

What is the new behavior?

Upgrade all actions + adapt command to use the new $GITHUB_ENV + fix test.sh + add "@types/node": "~14.14.31" devDependency

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Upgrade NodeJS to v14 and npm to v8
@SuperITMan SuperITMan added the ci label Dec 12, 2023
@SuperITMan SuperITMan requested a review from mhenkens December 12, 2023 09:18
This is required in order to maintain compatibility with TypeScript 3.x.
@SuperITMan SuperITMan force-pushed the bugfix/fix-github-workflow branch from 7c36e8d to d65683a Compare December 12, 2023 10:23
@SuperITMan SuperITMan merged commit cbb22cd into NationalBankBelgium:master Dec 12, 2023
2 checks passed
@SuperITMan SuperITMan deleted the bugfix/fix-github-workflow branch December 12, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants