Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tsconfig): update support tsconfig@5 and angular@16 #516

Merged
merged 1 commit into from
May 29, 2024

Conversation

mhenkens
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@mhenkens mhenkens requested a review from SuperITMan May 29, 2024 07:29
@mhenkens mhenkens force-pushed the feature/angular16 branch from 165a7db to 2660649 Compare May 29, 2024 08:06
"disableExpressionLowering": true,
"disableTypeScriptVersionCheck": false,
"enableIvy": true,
"enableI18nLegacyMessageIdFormat": false,
Copy link
Member

@SuperITMan SuperITMan May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this rule enableI18nLegacyMessageIdFormat is set to false in TypeScript 4.9.x but not mentioned in tsconfig.json for TypeScript 5.0.x and 5.1.x ?

@mhenkens mhenkens force-pushed the feature/angular16 branch from 2660649 to 52de768 Compare May 29, 2024 10:06
@SuperITMan SuperITMan added typescript enhancement New feature or request labels May 29, 2024
@SuperITMan SuperITMan added this to the 1.11.0 milestone May 29, 2024
@SuperITMan SuperITMan merged commit f64c2bc into NationalBankBelgium:master May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants