-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): bump nouislider and @types/nouislider #3879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
069230a
to
7c34ac0
Compare
@SuperITMan could you review this pr ? |
730fdef
to
f5896f9
Compare
SuperITMan
requested changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small remarks +
Could adapt the following commit message.
Currently:
feat(stark-ui): adapt stark-slider component to work with the latest version of nouislider library
breaking change: StarkSliderConfig extends nouislider options therefore the start property is now
required
in next release the StarkSliderConfig interface may be removed
ts
ts
Could be
feat(stark-ui): adapt stark-slider component to work with the latest version of `nouislider` library
breaking change: `StarkSliderConfig` extends nouislider `Options` therefore the start property is now required. In the next major release, the `StarkSliderConfig` interface may be removed.
packages/stark-ui/src/modules/slider/components/slider-config.intf.ts
Outdated
Show resolved
Hide resolved
packages/stark-ui/src/modules/slider/components/slider.component.ts
Outdated
Show resolved
Hide resolved
Bumps [nouislider](https://github.com/leongersen/noUiSlider) and [@types/nouislider](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/nouislider). These dependencies needed to be updated together. Updates `nouislider` from 14.7.0 to 15.8.1 - [Release notes](https://github.com/leongersen/noUiSlider/releases) - [Changelog](https://github.com/leongersen/noUiSlider/blob/master/CHANGELOG.MD) - [Commits](leongersen/noUiSlider@14.7.0...15.8.1) Updates `@types/nouislider` from 9.0.10 to 15.0.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/nouislider) --- updated-dependencies: - dependency-name: nouislider dependency-type: direct:development update-type: version-update:semver-major - dependency-name: "@types/nouislider" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
f5896f9
to
829fe90
Compare
SuperITMan
approved these changes
Oct 11, 2024
…version of `nouislider` library breaking change: `StarkSliderConfig` extends nouislider `Options` therefore the start property is now required. In the next major release, the `StarkSliderConfig` interface may be removed.
829fe90
to
538ee05
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
javascript
Pull requests that update Javascript code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps nouislider and @types/nouislider. These dependencies needed to be updated together.
Updates
nouislider
from 14.7.0 to 15.8.1Release notes
Sourced from nouislider's releases.
... (truncated)
Changelog
Sourced from nouislider's changelog.
... (truncated)
Commits
b8a1b58
noUiSlider 15.8.1d53446c
Better example for center-fixed sliders44744a0
Merge pull request #1273 from Gudine/masterfc0c972
Converts getTooltips and getOrigins return types into arrays787ad0c
noUiSlider 15.8.0077c436
Merge pull request #1272 from 5andr0/master3406bc1
Bypass full updateOptions, fix eslint, check for two handles4697c18
Inverted Connects for unconstrained behaviorae93f93
Create RELEASE.md145dd0c
Update nouislider.d.tsUpdates
@types/nouislider
from 9.0.10 to 15.0.0Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)