Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed jobs on the nativephp database #538

Merged
merged 3 commits into from
Apr 3, 2025

Conversation

SRWieZ
Copy link
Member

@SRWieZ SRWieZ commented Apr 2, 2025

Not tested but should work.

@simonhamp
Copy link
Member

Can you describe the problem?

@SRWieZ
Copy link
Member Author

SRWieZ commented Apr 3, 2025

From Greg on discord:

I also notice when jobs that are added to the default queue in nativephp.sqlite fail they are put into the failed_jobs of database.sqlite when running native:dev

@SRWieZ
Copy link
Member Author

SRWieZ commented Apr 3, 2025

Those 3 configs use env('DB_CONNECTION', 'sqlite').

Before, we only replaced one dynamically. now it's fixed with all 3 being replaced.

Interestingly, the jobs table is not concerned because it uses 'connection' => env('DB_QUEUE_CONNECTION') and defaults to null, which I suppose takes the default. We can future-proof it by replacing this one too (in case users have replaced DB_QUEUE_CONNECTION in their .env)

@simonhamp
Copy link
Member

Ok this all makes sense! Thanks

We can future-proof it by replacing this one too (in case users have replaced DB_QUEUE_CONNECTION in their .env)

yeh let's do that!

@SRWieZ
Copy link
Member Author

SRWieZ commented Apr 3, 2025

done!

@SRWieZ SRWieZ merged commit 91f487c into main Apr 3, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants