Fix compression quality for image file formats like jpeg. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue introduced by NatronGitHub#31 that causes the compression quality to be ignored for formats with default compression like JPEG files. In the case of these files, the compression string was not being set and so the line that was appending the quality was actually triggering behavior that caused the quality value to be ignored. This in turn started causing the Natron-Tests to start failing because the JPEG writer used in these tests was not honoring the requested quality value. The fix here is simply to specify a valid base compression string for these formats so that when the quality is appended, the compression/codec part of the string is not empty. This avoids triggering logic in OIIO that ignores the quality values for empty compression/codec strings.
|
I've tested this with Natron & successfully run Natron-Tests on Windows. Without these changes Natron-Tests fails most of the test cases. With these changes Natron-Tests on Windows pass all the same tests that passed in the 2.5.0 release. |
rodlie
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced by #31 that causes the compression quality to be ignored for formats with default compression like JPEG files. In the case of these files, the compression string was not being set and so the line that was appending the quality was actually triggering behavior that caused the quality value to be ignored. This in turn started causing the Natron-Tests to start failing because the JPEG writer, used in these tests, was not honoring the requested quality value.
The fix here simply specifies a valid base compression string for these formats so that when the quality is appended, the compression/codec part of the string is not empty. This avoids triggering logic in OIIO that ignores the quality values for empty compression/codec strings.