Remove todo, add docs

Neamar · Dec 27, 2022 · 118ac3a · 118ac3a
1 parent 3600d72
commit 118ac3a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/app/src/main/java/fr/neamar/kiss/DataHandler.java b/app/src/main/java/fr/neamar/kiss/DataHandler.java
@@ -64,6 +64,10 @@ public class DataHandler extends BroadcastReceiver
             "app", "contacts", "shortcuts"
     );
 
+    /**
+     * Key for a preference that holds a String set of apps which are excluded from showing shortcuts.
+     * Each string in the set is the packageName of an app which may not show shortcuts.
+     */
     public final static String PREF_KEY_EXCLUDED_SHORTCUT_APPS = "excluded-shortcut-apps";
 
     private TagsHandler tagsHandler;

diff --git a/app/src/main/java/fr/neamar/kiss/loader/LoadAppPojos.java b/app/src/main/java/fr/neamar/kiss/loader/LoadAppPojos.java
@@ -94,7 +94,6 @@ private AppPojo createPojo(UserHandle userHandle, String packageName, String act
 
         boolean isExcluded = excludedAppList.contains(AppPojo.getComponentName(packageName, activityName, userHandle));
         boolean isExcludedFromHistory = excludedFromHistoryAppList.contains(id);
-        // TODO: are we checking for 'packageName' or 'id'? Test
         boolean isExcludedShortcuts = excludedShortcutsAppList.contains(packageName);
 
         AppPojo app = new AppPojo(id, packageName, activityName, userHandle, isExcluded, isExcludedFromHistory, isExcludedShortcuts);