Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-release when a tag is pushed #137

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Auto-release when a tag is pushed #137

merged 1 commit into from
Mar 1, 2024

Conversation

ajfloeder
Copy link
Contributor

Documenation should auto-release too.

Signed-off-by: Anthony Floeder <[email protected]>
@roehrich-hpe
Copy link
Contributor

No, we don't want this. This already has workflows that handle the release.

@ajfloeder
Copy link
Contributor Author

Any idea why the release wasn't auto generated then? I ran the gh command to force the release.

@bdevcich
Copy link
Contributor

No, we don't want this. This already has workflows that handle the release.

We have a workflow that publishes the documentation once you've already released, but I don't think we have the automation from tag -> release.

@roehrich-hpe
Copy link
Contributor

Any idea why the release wasn't auto generated then? I ran the gh command to force the release.

We may need to do more experimenting here. But this workflow definitely doesn't belong here, at least not in the same form that we use for code repos. We should push a tag, and create a release...and that should trigger this: https://github.com/NearNodeFlash/NearNodeFlash.github.io/blob/main/.github/workflows/release.yaml#L3-L5

@ajfloeder
Copy link
Contributor Author

I'm confused as to why the code I copied here is wrong.

In order to generate release v0.0.10, I had to:

  1. create and push the tag
  2. (wait for a long time to release no release was coming)
  3. manually run gh release create --generate-notes --verify-tag -p v0.0.10 -t "Release v0.0.10"

which in turn caused the documentation with the release tag to be published.

@ajfloeder ajfloeder merged commit 6d218f2 into main Mar 1, 2024
2 checks passed
@ajfloeder ajfloeder deleted the add-release-action branch March 1, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants