Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lustre Layout documentation to Storage Profile #174

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

matthew-richerson
Copy link
Contributor

This commit adds documentation for the Lustre layout fields in the NnfStorageProfile.

This commit adds documentation for the Lustre layout fields in the NnfStorageProfile.

Signed-off-by: Matt Richerson <[email protected]>
@@ -232,6 +232,55 @@ data:
[...]
```

### Target Layout

Users may want Lustre file systems with different performance characteristics. For example, a user job with a single compute node accessing the Lustre file system would see acceptable performance from a single OSS. A FPP workload might want as many OSSs as posible to avoid contention.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Users may want Lustre file systems with different performance characteristics. For example, a user job with a single compute node accessing the Lustre file system would see acceptable performance from a single OSS. A FPP workload might want as many OSSs as posible to avoid contention.
Users may want Lustre file systems with different performance characteristics. For example, a user job with a single compute node accessing the Lustre file system would see acceptable performance from a single OSS. An FPP workload might want as many OSSs as possible to avoid contention.


Only one of `scale` and `count` can be set for a particular target type.

The `DirectiveBreakdown` for "create_persistent" #DWs won't include the constraint from `colocateCompute=true` since there may not be any compute nodes associated with the job.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `DirectiveBreakdown` for "create_persistent" #DWs won't include the constraint from `colocateCompute=true` since there may not be any compute nodes associated with the job.
The `DirectiveBreakdown` for `create_persistent` #DWs won't include the constraint from `colocateCompute=true` since there may not be any compute nodes associated with the job.

You wrap create_presistent in backticks below, so it makes sense to be consistent here


`colocatedComputes=false` may be useful for placing MDTs on NNF nodes without an OST (within the same file system).

The `count` fields may be useful when creating a persistent file system since the job with the `create_persistent` directive may only have a single compute node.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fields? or field?

Signed-off-by: Matt Richerson <[email protected]>
@matthew-richerson matthew-richerson merged commit 85ec1c0 into main Jul 2, 2024
1 check passed
@matthew-richerson matthew-richerson deleted the lustre-layout branch July 2, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants