Add finalizers to LustreFileSystems #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LustreFileSystems can be removed before Data Movement worker pods have unmounted them. This change adds a finalizer to the LustreFileSystems to indicate that DM worker pods are using it. Once the LustreFileSystem has been marked for deletion, we then ensure that the worker pods are no longer using that volume. Then, the finalizer can be removed to indicate that nothing is using the LustreFileSystem. Signed-off-by: Blake Devcich <[email protected]>
matthew-richerson
approved these changes
Nov 2, 2023
| for _, vol := range ds.Spec.Template.Spec.Volumes { | ||
| if lustre.Name == vol.Name { | ||
| log.Info("Requeue: wait for daemonset to drop lustrefilesystem volume", "lustrefilesystem", lustre) | ||
| return &ctrl.Result{RequeueAfter: 1 * time.Second}, nil |
There was a problem hiding this comment.
This controller has an Owns(&appsv1.DaemonSet{}), so the requeue shouldn't be necessary.
| // wait for pods to restart | ||
| log.Info("Requeue: wait for daemonset to restart pods after dropping lustrefilesystem volume", | ||
| "desired", d, "updated", ds.Status.UpdatedNumberScheduled, "ready", ds.Status.NumberReady) | ||
| return &ctrl.Result{RequeueAfter: 1 * time.Second}, nil |
There was a problem hiding this comment.
Same thing here. When the DaemonSet changes, it will trigger the reconciler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LustreFileSystems can be removed before Data Movement worker pods have
unmounted them. This change adds a finalizer to the LustreFileSystems to
indicate that DM worker pods are using it. Once the LustreFileSystem has
been marked for deletion, we then ensure that the worker pods are no
longer using that volume. Then, the finalizer can be removed to indicate
that nothing is using the LustreFileSystem.
Signed-off-by: Blake Devcich [email protected]