Move DataMovementManager to nnf-sos and rename to NnfDataMovementManager #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves DMM to nnf-sos so that nnf-sos can use the DMM. This enables nnf-sos to check if the DMM is ready before proceeding with copy_in/copy_out directives. * Moved type.go file and rbac roles to nnf-sos * Removed `crd/` - there are no data movement types defined here anymore * Added README.md to `api` to explain the types are in nnf-sos * Update references to NnfDataMovementManager and also NnfDataMovement * Re-vendored nnf-sos
roehrich-hpe
approved these changes
Nov 13, 2023
Signed-off-by: Blake Devcich <[email protected]>
NateThornton
approved these changes
Nov 13, 2023
Haha, yes 😉 But also, we need sos to be able to check when dmm is ready. I have an additional PR coming that ties the worker daemonset status into DMM's ready flag. So when things like global lustre are still being mounted into the workers, sos doesn't try to do data movement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves DMM to nnf-sos so that nnf-sos can use the DMM. This enables
nnf-sos to check if the DMM is ready before proceeding with
copy_in/copy_out directives.
crd/- there are no data movement types defined here anymoreapito explain the types are in nnf-sos