Use GOMAXPROCS for MaxConcurrentReconciles #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdevcich
requested review from
ajfloeder,
matthew-richerson and
roehrich-hpe
Update this to be consistent with our other controllers. I believe this equates to 128, but setting this programmatically is probably the better way to go. Signed-off-by: Blake Devcich <[email protected]>
bdevcich
force-pushed
the
max-reconcilers
branch
from
26bf60d to
16f5ce0
Compare
matthew-richerson
approved these changes
Nov 27, 2023
ajfloeder
approved these changes
Nov 27, 2023
| return ctrl.NewControllerManagedBy(mgr). | ||
| For(&nnfv1alpha1.NnfDataMovement{}). | ||
| WithOptions(controller.Options{MaxConcurrentReconciles: 128}). | ||
| WithOptions(controller.Options{MaxConcurrentReconciles: maxReconciles}). |
There was a problem hiding this comment.
GOMAXPROCS defaults to the number of CPUs. How many are on a rabbit?
The cmd.wait() likely allows Go to pick up another go proc, if one is available. So this controller can probably handle many more data movements than GOMAXPROCS would allow.
I wonder if this controller should even have a max setting.
There was a problem hiding this comment.
Do you mean that it should default to 1?
There was a problem hiding this comment.
hmm, no. I hadn't realized that was the default. It should be a high number. Let's stay with 128 until we see a reason to change it.
There was a problem hiding this comment.
This does equal 128 on the rabbit nodes:
root@nnf-dm-worker-pctgf:~# ./maxprocs
maxReconciles: 128
root@nnf-dm-worker-pctgf:~# nproc
128Here's the code for ./maxprocs:
package main
import (
"fmt"
"runtime"
)
func main() {
maxReconciles := runtime.GOMAXPROCS(0)
fmt.Printf("maxReconciles: %d\n", maxReconciles)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update this to be consistent with our other controllers. I believe this equates to 128, but setting this programmatically is probably the better way to go.