Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call split on element is not a string #166

Closed

Conversation

hsiaosiyuan0
Copy link

Hi,

this CL can fix this issue #146, only one line involved

@hsiaosiyuan0
Copy link
Author

hsiaosiyuan0 commented Jan 9, 2024

@evgenykuzyakov could you please take a review for this CL

@matiasberaldo
Copy link
Contributor

I think the if condition should be like the one below, otherwise falsy values will pass through:
!element || typeof element !== "string"

@hsiaosiyuan0
Copy link
Author

hsiaosiyuan0 commented Jan 24, 2024

I think the if condition should be like the one below, otherwise falsy values will pass through: !element || typeof element !== "string"

do you have any actual falsy value for a example? it does not exists in my thread, however if there were, it passes through the previous logic as how it had been processed before.

@hsiaosiyuan0
Copy link
Author

hsiaosiyuan0 commented Jan 24, 2024

close it to save time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants