feat: Sign message #193
Merged
feat: Sign message #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frol
approved these changes
May 17, 2024
There was a problem hiding this comment.
@evgenykuzyakov Looks good to me, but I don't know if the version update should be part of this PR or a separate effort and whether we should merge it into dev branch first
feat: clear location hash method added
…anged to be more familiar to developers
CHANGELOG.md
Outdated
| @@ -1,5 +1,16 @@ | |||
| # Changelog | |||
|
|
|||
| ## 2.6.2 | |||
There was a problem hiding this comment.
Suggested change
| ## 2.6.2 | |
| ## Pending |
src/lib/vm/vm.js
Outdated
| @@ -1612,6 +1612,21 @@ export default class VM { | |||
| }; | |||
|
|
|||
| const Near = { | |||
| signMessage: (...args) => { | |||
| if (args.length < 3) { | |||
There was a problem hiding this comment.
Let's add similar API to call, where if the only 1 argument is given and it's an object, then it passes it directly
…it's an object, then it passes it directly
# Conflicts: # CHANGELOG.md # dist/index.js
evgenykuzyakov
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the use of the signMessage method from the wallet-selector. The user can sign a message with any of the connected wallets for further signature verification on a third-party authentication server.