Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling in Scav's updated ministation to replace the existing ministation. #3465

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

MistakeNot4892
Copy link
Contributor

Description of changes

  • Adds head roles and rep role to ministation roster.
  • Adds overmap and multiz support to ministation.
  • Pulls in various other map changes from ScavStation.

Why and what will this PR improve

Given that this is the map that ScavStation runs rounds on, it is a much more complete and tested experience than the existing ministation.

Authorship

I just copied in the code and descavved it, I believe most of the changes are @Devchord and @Qumefox (and other scavs).

Changelog

🆑
tweak: Updated ministation from ScavStation. Lots of changes, see PR.
/:cl:

@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. ❄️frozen❄️ Do not merge until the dev freeze is over. labels Oct 22, 2023
@MistakeNot4892 MistakeNot4892 force-pushed the mini branch 3 times, most recently from 583f450 to 70eb3dd Compare October 22, 2023 11:59
@out-of-phaze
Copy link
Member

I feel like we really need to still have a functional non-multiz/1z (at least mostly, I know there's already space.dmm) map for testing purposes. Up until now I've been using Ministation for that, but this seems to add 3 new z-levels.

@MistakeNot4892
Copy link
Contributor Author

Misclick :(

@MistakeNot4892 MistakeNot4892 removed the ❄️frozen❄️ Do not merge until the dev freeze is over. label Nov 4, 2023
out-of-phaze
out-of-phaze previously approved these changes Dec 1, 2023
Copy link
Member

@out-of-phaze out-of-phaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concern with OpenDream is apparently no longer true, so this seems fine.

@comma comma merged commit d65e49b into NebulaSS13:dev Dec 17, 2023
10 checks passed
@MistakeNot4892 MistakeNot4892 deleted the mini branch February 11, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants