Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vitals sensors are now handled by an accessory. #3484

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Vitals sensors are now handled by an accessory. #3484

merged 2 commits into from
Dec 6, 2023

Conversation

MistakeNot4892
Copy link
Contributor

Description of changes

Moves suit sensors stuff onto an accessory.

Why and what will this PR improve

Allows me to do dark things to the /under type.

Authorship

Myself.

Changelog

🆑
tweak: Suit sensors are now an accessory on your uniform that can be removed.
/:cl:

@MistakeNot4892 MistakeNot4892 added the work in progress This PR is under development and shouldn't be merged. label Nov 2, 2023
@MistakeNot4892 MistakeNot4892 force-pushed the sensors branch 8 times, most recently from 25e7e95 to d590ecf Compare November 2, 2023 09:23
@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. ❄️frozen❄️ Do not merge until the dev freeze is over. and removed work in progress This PR is under development and shouldn't be merged. labels Nov 2, 2023
@MistakeNot4892 MistakeNot4892 marked this pull request as ready for review November 2, 2023 09:23
@MistakeNot4892 MistakeNot4892 force-pushed the sensors branch 4 times, most recently from 1ea2bb7 to 83704df Compare November 2, 2023 10:12
@MistakeNot4892 MistakeNot4892 removed the ❄️frozen❄️ Do not merge until the dev freeze is over. label Nov 4, 2023
out-of-phaze
out-of-phaze requested changes Dec 1, 2023
View reviewed changes
Copy link
Member

@out-of-phaze out-of-phaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prisoner and test subject uniform sensors should use removable = FALSE or canremove = FALSE, and the accessory removal verb should check whichever one you go for. Other than that, good to go.

@MistakeNot4892
Copy link
Contributor Author

Implemented using removable, works in testing.

@MistakeNot4892 MistakeNot4892 mentioned this pull request Dec 1, 2023
Closed
4 tasks
out-of-phaze
out-of-phaze approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@out-of-phaze out-of-phaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does kind of make me wonder why we'd have the removable variable at all instead of just an is_removable() proc on accessories, but it works regardless.

@out-of-phaze out-of-phaze merged commit f86861b into NebulaSS13:dev Dec 6, 2023
10 checks passed
NebulaSS13Bot added a commit that referenced this pull request Dec 6, 2023
@NebulaSS13Bot
Automatic changelog generation for PR #3484 [ci skip]
eae8b20
@MistakeNot4892 MistakeNot4892 deleted the sensors branch February 11, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@out-of-phaze out-of-phaze out-of-phaze approved these changes

Assignees
No one assigned
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MistakeNot4892 @out-of-phaze