January 8, 2024 Lighthouse downstream fixes/improvements #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds a unit test for wall object offsets.
Fixes a ton of wall objects with incorrect offsets on all maps except Exodus which had so many and I was tired... please, if someone wants to keep Exodus around, enable the test for it and fix the rest.
Adds @positive and @Negative to update_paths.py.
Adds a migration for fixing some very basic wallobj issues, using the above format.
Fixes the migration for #3560, making it affect subtypes.
Why and what will this PR improve
Fixes from downstream, moved upstream.