Unifying adjust/get/set damage procs. #3817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
out-of-phaze
approved these changes
Mar 20, 2024
|
I meant to mark this WIP/DNM after I noticed the args were out of order :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Replaces
(get|set|adjust)\w+Loss\(\)withtake_damage,set_damageandheal_damage, which are just wrapper procs calling the sub-proc currently.Why and what will this PR improve
More reviewable/easier to keep from conflicting than the rest of #3418.
Authorship
Myself.
Changelog
Nothing player-facing.