Move the supermatter crystal and related content into a modpack #4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
out-of-phaze
added
do not merge
out-of-phaze
force-pushed
the
modular/supermatter
branch
4 times, most recently
from
eee801a to
825f4de
Compare
MistakeNot4892
previously approved these changes
Jan 7, 2025
out-of-phaze
dismissed
MistakeNot4892’s stale review
The merge-base changed after approval.
MistakeNot4892
added
needs rebase/retarget
out-of-phaze
force-pushed
the
modular/supermatter
branch
from
825f4de to
0833823
Compare
MistakeNot4892
removed
the
needs rebase/retarget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Moves the supermatter crystal and related content into a modpack.
Depends on #4690.
I have no clue how I'd test this. Engine setup verb, check that the UIs work, fix atmos grief verb, try a delam?
Why and what will this PR improve
Moves the SM into a modpack, which is a good proof-of-concept for "what if we modpacked base-game SS13 features?" Like, I know that Shaded Hills doesn't suffer at all from "supermatter crystals existing in the game code but being inaccessible," but modpacking it highlights places our modularity is lacking, and it makes it easier for codebases to pick-and-choose what they want in their lore; some might not want supermatter crystals to be orderable at all, for example.
Authorship
Me.
Changelog
Shouldn't be any user-facing changes?