Moving Shaded Hills level data and submap logic into fantasy modpack. #4717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
force-pushed
the
rework/fantasy_submaps
branch
2 times, most recently
from
0bb935a to
777cff3
Compare
out-of-phaze
previously requested changes
Jan 14, 2025
code/game/area/areas.dm
Outdated
| @@ -93,6 +94,10 @@ var/global/list/areas = list() | |||
| ..() | |||
|
|
|||
| /area/Initialize() | |||
| if(additional_fishing_results) | |||
There was a problem hiding this comment.
miiiiight be worth using a LAZYLEN check just to avoid creating a zero-len fishing_results list if someone sets additional_fishing_results to an empty list, but it's not a huge deal
also i think we could probably null out additional_fishing_results after this but i'm not sure
EDIT: not blocking, the other comment is though
| sound_env = GENERIC | ||
| ambience = list() | ||
|
|
||
| /area/fantasy/outside |
There was a problem hiding this comment.
this area has no name by default. it should probably be set to "\improper Wilderness" or something to match /area/shaded_hills/outside being named "\improper Grasslands"?
MistakeNot4892
force-pushed
the
rework/fantasy_submaps
branch
from
777cff3 to
0b10d3e
Compare
MistakeNot4892
force-pushed
the
rework/fantasy_submaps
branch
from
0b10d3e to
f263cdf
Compare
out-of-phaze
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title. This is largely just reorganisation and proc merging as Pyrelight wants to use this logic for other maps.