Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality grep checks #4760

Merged

Conversation

out-of-phaze
Copy link
Member

Description of changes

  • Adds a check for the tag var in code, expanding it from just checking in maps.
  • Removes unnecessary usage of the tag var.
  • Replaces all current uses of direct_output with specialized helpers, in preparation for allowing drop-in optional replacement for downstreams that want to opt into things like rust-g to improve performance.
  • Improves a lot of our grep checks to reduce false positives.
  • Removes 15 in world loops, either deleting them entirely because they're dead code, or replacing them with other lists.
  • Fixes redundant code in supply pack setup. This just got thrown in because eh, why not.

Why and what will this PR improve

Improves code quality across the board.

@out-of-phaze out-of-phaze added the ready for review This PR is ready for review and merge. label Jan 18, 2025
Copy link
Contributor

@MistakeNot4892 MistakeNot4892 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default mobloc cache var needs removal or reimplementation.

@MistakeNot4892 MistakeNot4892 added awaiting author This PR is awaiting action from the author before it can be merged. and removed ready for review This PR is ready for review and merge. labels Jan 19, 2025
@out-of-phaze out-of-phaze force-pushed the codequality/grep-checks-redux branch from 417cfbe to 9e28314 Compare January 21, 2025 21:40
@MistakeNot4892
Copy link
Contributor

Unit tests appear to be timing out.

@out-of-phaze out-of-phaze force-pushed the codequality/grep-checks-redux branch 2 times, most recently from d01e724 to 605cfe0 Compare January 21, 2025 23:56
@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. and removed awaiting author This PR is awaiting action from the author before it can be merged. labels Jan 22, 2025
MistakeNot4892
MistakeNot4892 previously approved these changes Jan 22, 2025
@MistakeNot4892 MistakeNot4892 added awaiting author This PR is awaiting action from the author before it can be merged. has conflicts This PR needs updating and conflict resolution before it can be merged. and removed ready for review This PR is ready for review and merge. labels Jan 23, 2025
@out-of-phaze out-of-phaze force-pushed the codequality/grep-checks-redux branch from 605cfe0 to c8ff480 Compare January 23, 2025 21:58
@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. and removed awaiting author This PR is awaiting action from the author before it can be merged. has conflicts This PR needs updating and conflict resolution before it can be merged. labels Jan 23, 2025
@MistakeNot4892 MistakeNot4892 merged commit b2b42ef into NebulaSS13:dev Jan 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants