-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code quality grep checks #4760
Merged
MistakeNot4892
merged 6 commits into
NebulaSS13:dev
from
out-of-phaze:codequality/grep-checks-redux
Jan 23, 2025
Merged
Improve code quality grep checks #4760
MistakeNot4892
merged 6 commits into
NebulaSS13:dev
from
out-of-phaze:codequality/grep-checks-redux
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
requested changes
Jan 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default mobloc cache var needs removal or reimplementation.
MistakeNot4892
added
awaiting author
This PR is awaiting action from the author before it can be merged.
and removed
ready for review
This PR is ready for review and merge.
labels
Jan 19, 2025
out-of-phaze
force-pushed
the
codequality/grep-checks-redux
branch
from
January 21, 2025 21:40
417cfbe
to
9e28314
Compare
Unit tests appear to be timing out. |
out-of-phaze
force-pushed
the
codequality/grep-checks-redux
branch
2 times, most recently
from
January 21, 2025 23:56
d01e724
to
605cfe0
Compare
MistakeNot4892
added
ready for review
This PR is ready for review and merge.
and removed
awaiting author
This PR is awaiting action from the author before it can be merged.
labels
Jan 22, 2025
MistakeNot4892
previously approved these changes
Jan 22, 2025
MistakeNot4892
added
awaiting author
This PR is awaiting action from the author before it can be merged.
has conflicts
This PR needs updating and conflict resolution before it can be merged.
and removed
ready for review
This PR is ready for review and merge.
labels
Jan 23, 2025
out-of-phaze
force-pushed
the
codequality/grep-checks-redux
branch
from
January 23, 2025 21:58
605cfe0
to
c8ff480
Compare
MistakeNot4892
added
ready for review
This PR is ready for review and merge.
and removed
awaiting author
This PR is awaiting action from the author before it can be merged.
has conflicts
This PR needs updating and conflict resolution before it can be merged.
labels
Jan 23, 2025
MistakeNot4892
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
tag
var in code, expanding it from just checking in maps.tag
var.direct_output
with specialized helpers, in preparation for allowing drop-in optional replacement for downstreams that want to opt into things like rust-g to improve performance.in world
loops, either deleting them entirely because they're dead code, or replacing them with other lists.Why and what will this PR improve
Improves code quality across the board.